@karan-96, thanks for your PR! By analyzing the history of the files in this pull request, we identified @davids549, @gibson042 and @flesler to be potential reviewers.

Thanks for the PR. However, more things are needed for this to land:

1. jQuery.nodeName has to stop being used internally; its definition has to be extracted to a separate AMD module under src/core/var/nodeName.js and included via AMD where needed; the jQuery.nodeName definition should be reduced to something like:

define( [
	/* other code */
	"./core/var/nodeName"
], function ( /* other code */ nodeName ) {

"use strict";

/* other code */

jQuery.nodeName = nodeName;

} );

2. Tests for jQuery.nodeName have to be moved to test/unit/deprecated.js as well.

You can see 1b9575b for what was needed for the jQuery.isArray deprecation; similar actions will be needed here with the exception that the deprecated method is this time not 100% equivalent to a native one so we still need to keep the code in a separate module (in src/core/var/nodeName.js that you need to create as I mentioned).

Would you like to apply those changes? If you have any doubts about what has to be done just ask.

yes i would like to work on this.

Cool! Let us know if you stumble upon any problems.

@mgol sir, my 'src/core/var/nodeName.js' looks like

define(function( elem, name ) {
	"use strict";

	return elem.nodeName && elem.nodeName.toLowerCase() === name.toLowerCase();
} );

and i need to include its definition(the one you mentioned above) via AMD everywhere jQuery.nodeName has been used. Am i getting your 1st point correct?

@karan-96 The function passed to define defines a module that should return what you want to export so you need to wrap your function in another. Look at https://github.com/jquery/jquery/blob/3.1.1/src/css/addGetHookIf.js for how it can be done.

Also, now that I look at it it probably doesn't have to be a var-module so you can put it in src/core/nodeName.js instead of src/core/var/nodeName.js.

@mgol sir,
1.How can I include nodeName function in /test files? I tried “define” like I did in /src files but i found errors when I built jquery. So after exploring the directory I found “test/.eslintrc.json”. And I found “define” : “false” there under globals option. Is it because of this that I am not able to use “define”? And How should I proceed now?

2.And do i have to write a new test for nodeName and include it in deprecate.js?

@karan-96 In tests just use jQuery.nodeName; we're testing what is publicly exposed, not private modules. Also, you don't have to write any tests, just find exsiting ones and move them to test/unit/deprecated.js.

@karan-96 Do you think you'll have time to move the unit tests soon?

@mgol ,i did not find any test for jquery.nodeName. please tell me if i am missing something?

@karan-96 You're right, this is a private API so there was no tests for it.

A couple remarks:

1. Could you rebase this PR over latest master? There is a minor conflict in src/deprecated.js.
2. After you rebase you should notice a few extra uses of jQuery.nodeName in src/traversing.js.
3. I was wrong that you can just use jQuery.nodeName in tests, sorry for that. We'll want to remove the method one day and it being used in tests will be problematic. All the mentions should be replace by bare elem.nodeName, sometimes passed through toLowerCase() but not always - you can verify if you replaced it incorrectly when you run the tests.
4. I've noticed you added the entries for nodeName in the dependencies lists of various modules to the end of the list. They should be placed near other entries for the same module, e.g. in src/offset.js the entry "./core/nodeName" should be placed after "./core/access" not "./css/support".

Could you apply those changes?

yes , i will apply these changes.

@mgol sir i have applied the changes.please review them ?

Landed, thanks @karan-96!

thank you all for your guidance throughout.