Release: migrate release process to release-it #5306
Conversation
| @@ -1,3 +1,5 @@ | |||
| Authors ordered by first contribution. | |||
There was a problem hiding this comment.
This line was accidentally removed at some point. The main branch still has it.
| Alex <aleksandrosansan@gmail.com> | ||
| Timo Tijhof <krinkle@fastmail.com> | ||
| Gabriela Gutierrez <gabigutierrez@google.com> | ||
| Dimitri Papadopoulos Orfanos <3234522+DimitriPapadopoulos@users.noreply.github.com> |
There was a problem hiding this comment.
I know the number of changes looks odd, but I've confirmed that grunt authors has the same result. My guess is this has something to do with privacy rules being respected more accurately in git logs.
There was a problem hiding this comment.
No, and I actually made these changes long ago on purpose... This was to certify that contributions to Sizzle matter as much to jQuery as contributions to the main jQuery repo. I changed the file so that the entries are ordered by the first contribution to any of those two repositories. I'd like to preserve that.
Cf. https://github.com/jquery/jquery/pull/4395/files#diff-b897336dda0579c40f3623b68eb6652ded79e206f4cf1af7ceb24b683fd46ff1 & https://github.com/jquery/jquery/pull/5113/files#diff-b897336dda0579c40f3623b68eb6652ded79e206f4cf1af7ceb24b683fd46ff1
There was a problem hiding this comment.
I see. Let's incorporate that into the authors script then.
There was a problem hiding this comment.
It’d be interesting to see if I made any mistakes in this ordering. 😅
There was a problem hiding this comment.
I've updated the authors script to clone the sizzle repo, combine the authors, sort by their first contribution, ensure they are unique by name, and then run cleanup so the sizzle repo doesn't stick around.
One case that I found interesting is Timo's entry. I noticed that his old email is still in the authors, whereas both emails were in there before. I think we only need the one; the email will automatically update when Timo updates the mailmap.
| return changelog; | ||
| } | ||
|
|
||
| generate(); |
There was a problem hiding this comment.
Some of this was pulled directly from changelogplease, but grouping by component with ## headers and using marked to then convert to HTML is what's new. changelog.md is also written to a file now and I've intentionally left that out of the .npmignore so it's included in releases.
*Authors*
- Checking and updating authors has been migrated
to a custom script in the repo
*Changelog*
- changelogplease is no longer maintained
- generate changelog in markdown for GitHub releases
- generate changelog in HTML for blog posts
*dist*
- clone dist repo, copy files, and commit/push
- commit tag with dist files on the 3.x-stable branch;
remove dist files from main branch after release
*cdn*
- clone cdn repo, copy files, and commit/push
- create versioned and unversioned copies in cdn/
- generate md5 sums and archives for Google and MSFT
*GH actions*
- add GitHub workflow for running releases in CI
- releases can be triggered from GitHub; args
can be added for pre releases
- npm publish can now run with provenance
Fixes jquery/jquery-release#114
|
@timmywil are you targeting it at 4.0 or 3.x? I may not have time to do the full review before September 4 (it may happen but no promises). |
|
@mgol I mostly wanted to see how hard it was so I hadn't decided yet, but I think I should release 3.7.1 and we can keep churning on this. |
|
Closing in favor of #5522 |
Summary
Authors
Changelog
dist
-preversion. It's a practice we invented and have been doing a long time, but I'm not sure is actually necessary. It simplifies some release-it steps to not do it, which bases it's automatic version detection on the assumption that the version in package.json is the last version released. Besides, our-preversion is often wrong anyway (for instance, when the next version is going to be a minor or major instead of a patch). If jquery-git.js is a concern, it does already include the SHA in the header and I think we could remove the version there completely.cdn
GH actions
Fixes jquery/jquery-release#114
Checklist