Build: migrate grunt authors to a custom script #5395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the new script pulls all authors from the Sizzle repo - added temporary grunt task for releases
mgol
requested changes
Jan 22, 2024
Comment on lines
+213
to
+217
| const done = this.async(); | ||
| const { getAuthors } = require( "./build/release/authors.js" ); | ||
| const authors = await getAuthors(); | ||
| console.log( authors.join( "\n" ) ); | ||
| done(); |
Member
There was a problem hiding this comment.
I like this pattern of using an async function and calling done() in a way that looks synchronous. 🙂
Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I started putting together the release and ran into a stale authors list. I then ran
grunt update-authors, but forgot that we want to continue including Sizzle authors and I already wrote a script for that. This pulls that script from #5306.I've also added a grunt task that uses the updated script. Since we're not using the updated release process just yet, we need that for the jquery-release script. The grunt task logs all authors to console and jquery-release does its own check.
Checklist