-
Notifications
You must be signed in to change notification settings - Fork 940
Add eslint as linter tool #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 18 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6315322
Build: Configure eslint
JuanMaRuiz 54be4f2
Build: Configure eslint
JuanMaRuiz ed18cae
Build: Configure eslint
JuanMaRuiz 4efc809
Build: Fixing eslint errors
JuanMaRuiz 97f2bfe
Build: Fixing eslint line length errors
JuanMaRuiz 49d0a94
Build: Fixing eslint non nesting ternary
JuanMaRuiz 624e7ce
Build: Removed old jshint grunt task
JuanMaRuiz 12ee0c5
Build: Configure eslint
JuanMaRuiz 13a8efa
Build: Configure eslint
JuanMaRuiz 57c01b7
Build: Configure eslint
JuanMaRuiz a80d39b
Build: Configure eslint
JuanMaRuiz c888650
Merge branch 'fix-438-use-eslint' of https://github.com/JuanMaRuiz/si…
JuanMaRuiz 5c763ff
Build: Configure eslint - PR requested changes
JuanMaRuiz 4cc4ae1
Build: Configure eslint
JuanMaRuiz 7b96d79
Build: Configure eslint for test folder
JuanMaRuiz e1e793e
Merge branch 'master' into fix-438-use-eslint
JuanMaRuiz 57efcda
Build: Configure eslint for test folder
JuanMaRuiz 03f498c
Build: Configure eslint for test folder
JuanMaRuiz 8fae5dd
Build: Configure eslint - PR request
JuanMaRuiz 24d0a94
Build: Configure eslint - PR improvements
JuanMaRuiz 684520f
Build: Configure eslint - PR improvements
JuanMaRuiz f258209
Build: Configure eslint - PR improvements
JuanMaRuiz acc8a1c
Build: Configure eslint - PR improvements
JuanMaRuiz 1d2d470
Build: Configure eslint - PR improvements
JuanMaRuiz fb6b2f2
Build: Removed strict configuration in eslint
JuanMaRuiz ea5dca1
Build: Improve eslint configuration, fix configuration errors
JuanMaRuiz 9f12b3b
Build: Improve eslint configuration, fix configuration errors
JuanMaRuiz 09d6a26
Build: Some PR improvements and re-indents
JuanMaRuiz 7c3f27e
Build: Improve eslint configuration, changed location and setTimeout
JuanMaRuiz bfe54cd
Merge remote-tracking branch 'origin/fix-438-use-eslint' into fix-438…
JuanMaRuiz e8a2553
Build: Reverted dot notation to bracket notation in sizzle
JuanMaRuiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| external | ||
| node_modules | ||
| *.min.js | ||
| dist/** | ||
| build/** | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "root": true, | ||
mgol marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| "extends": "jquery", | ||
|
|
||
| // Support: | ||
| // - Desktop: Chrome 16+, Edge 12+, Firefox 3.6+, Internet Explorer 7+1, Opera 11.6+, Safari 4.0+ | ||
| // - Mobile: Android 2.3+, iOS 5.1+ | ||
| // More info: https://github.com/jquery/sizzle/wiki#-browser-support | ||
mgol marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| "parserOptions": { | ||
| "ecmaVersion": 3 | ||
| }, | ||
|
|
||
| // The browser env is not enabled on purpose so that code takes | ||
| // all browser-only globals from window instead of assuming | ||
| // they're available as globals. This makes it possible to use | ||
| // jQuery with tools like jsdom which provide a custom window | ||
| // implementation. | ||
| "env": { | ||
| "node": true | ||
| }, | ||
|
|
||
| "globals": { | ||
| "window": true, | ||
| "jQuery": true, | ||
| "define": true, | ||
| "module": true | ||
| }, | ||
|
|
||
| "rules": { | ||
| "strict": ["error", "function"] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "extends": ".eslintrc-browser.json", | ||
| "rules": { | ||
| "no-nested-ternary": 1 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,4 @@ | |
| .DS_Store | ||
| node_modules | ||
| bower_components | ||
| .idea/ | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.