Setting imshow(animated=True) still show does not show an image #30052
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
rcomer
left a comment
There was a problem hiding this comment.
Hi @alphanoobie thank you for your contribution and sorry that nobody responded sooner. This PR looks good and I just have some suggestions about the test.
|
Hi @alphanoobie do you think you will have time to come back to this? |
|
From the links it looks like this was part of a class project, so I suspect that @alphanoobie has moved on with their life. I think this was a quality contribution and so it would be good to get it in anyway - it stalled because we didn't get around to reviewing it sooner. My review suggestions above do not affect the functionality or intent of the test. What do other devs think? |
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
…lotlib#30052) --------- Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
fixes #18985
PR summary
PR checklist