Fix: respect animated=True for imshow; add regression test (closes #18985) #30643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
|
Thanks for your willingness to contribute. However, there's already a more mature solution available in #30052. Per our contribution policy, please do not submit concurrent pull requests without prior consultation. Also the mock approach to testing there is somewhat more efficient than comparing to a reference image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AxesImage objects created by imshow(..., animated=True) were still drawn on the initial render. Other artists marked animated=True are skipped until explicitly drawn, so this was inconsistent.
This PR removes the special-case that exempted AxesImage from the animated filter in _AxesBase.draw. Animated images are now treated the same as other animated artists on first draw. A regression test asserts visual equality with a blank reference.
Why needed: makes animated=True semantics consistent across artist types and prevents confusing initial frames in animation workflows.
PR checklist