MNT: Pending-deprecate setting colormap extremes in-place #30531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ff2086 to
b83c694
Compare
b83c694 to
e2090f4
Compare
QuLogic
approved these changes
Sep 9, 2025
anntzer
approved these changes
Sep 16, 2025
Contributor
|
CI is legitimately failing (in particular because with_extremes is currently implemented in terms of set_foo (on a copy)). |
Member
Author
|
Some of the test failures due to the deprecation are difficult to manage with the current architectue. I've done a fefactoring in #30577 which will make this much simpler. Putting to draft until that is merged. |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Sep 18, 2025
Instead use the more modern ways to specify extremes during Colormap creation or using `with_extremes()` This is in preparation of deprecating setters in matplotlib#30531.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Sep 18, 2025
Instead use the more modern ways to specify extremes during Colormap creation or using `with_extremes()` This is in preparation of deprecating setters in matplotlib#30531.
bf856a0 to
07a46b2
Compare
Per matplotlib#29141 we have the long-term plan to make colormaps immutable. As a result, the in-place modifications have to be removed. We take this particularly slow with at least two minor releases of pending deprecation and two further releases of actual deprecations. As it's quite a common concept and migrating away will take time.
07a46b2 to
224828f
Compare
QuLogic
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #29141 we have the long-term plan to make colormaps immutable. As a result, the in-place modifications have to be removed. We take this particularly slow with at least two minor releases of pending deprecation and two further releases of actual deprecations. As it's quite a common concept and migrating away will take time.