MNT: Move all Colormap extremes setter logic into a single _set_extremes() #30577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
approved these changes
Sep 17, 2025
QuLogic
approved these changes
Sep 18, 2025
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring pulled out of #30531, because it's a standalone change that can be reviewed simple on its own. This will make the deprecation in #30531, and in particular handling of it in our test suite much simpler.
The behavior is 100% percent backward compatible as far as public API and behavior is concerned.