-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(parser): error when both projectService and project are set
#11333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): error when both projectService and project are set
#11333
Conversation
|
Thanks for the PR, @MariaSolOs! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t typecheck |
❌ Failed | 2m 10s | View ↗ |
nx test eslint-plugin --coverage=false |
✅ Succeeded | 5m 6s | View ↗ |
nx run-many -t lint |
✅ Succeeded | 3m 18s | View ↗ |
nx test eslint-plugin-internal --coverage=false |
✅ Succeeded | 10s | View ↗ |
nx run types:build |
✅ Succeeded | 5s | View ↗ |
nx test typescript-estree --coverage=false |
✅ Succeeded | 22s | View ↗ |
nx run integration-tests:test |
✅ Succeeded | 5s | View ↗ |
nx run generate-configs |
✅ Succeeded | 7s | View ↗ |
Additional runs (29) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-10 15:19:33 UTC
d4979a5 to
a8c4dc1
Compare
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just notes from quick preliminary review. I think we have a good path forward but should definitely let other team folks weigh in in #11319.
For now, I'll switch this PR to draft so it doesn't show up on the queue. But we can definitely un-draft it once the issue's discussion is done.
packages/typescript-estree/src/parseSettings/createParseSettings.ts
Outdated
Show resolved
Hide resolved
|
@JoshuaKGoldberg Thanks for the review! I'll wait for further thoughts from other maintainers before I continue working on this :) |
a8c4dc1 to
4ff2bd3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11333 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 518 518
Lines 52444 52454 +10
Branches 8690 8694 +4
=======================================
+ Hits 47548 47558 +10
Misses 4882 4882
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4ff2bd3 to
63d37d4
Compare
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source code change looks great. Just requesting adding tests: you should be able to use the existing vi.stubEnv-powered TYPESCRIPT_ESLINT_PROJECT_SERVICE ones around projectService in createParseSettings.test.ts as reference. LMK if that actually doesn't work though!
8f2fe95 to
65acef6
Compare
|
@JoshuaKGoldberg I'm having trouble fixing these tests as I can't reproduce the errors locally. I've been running |
|
Ah, yes, these come from explicitly setting typescript-eslint/.github/workflows/ci.yml Lines 244 to 245 in eb4ecd8
typescript-eslint/.github/workflows/ci.yml Lines 267 to 271 in eb4ecd8
I normally run Vitest directly when only a handful of files are failing: TYPESCRIPT_ESLINT_PROJECT_SERVICE=true yarn vitest packages/eslint-plugin-internal/tests/rules/plugin-test-formatting.test.ts |
65acef6 to
9c9c9b8
Compare
|
@JoshuaKGoldberg got it, thank you for the hint! |
f3f5baa to
cf71e1a
Compare
| languageOptions: { | ||
| parserOptions: { | ||
| project: './tsconfig.json', | ||
| projectService: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right way to fix the tests in files that just use the RuleTester.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good question. Ideally we wouldn't have to do anything in the plugin tests themselves. I'm poking around...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, yes, this is the right way.
Recapping for posterity: it's not apparent from the naming (sigh) but the TYPESCRIPT_ESLINT_PROJECT_SERVICE env variable's purpose isn't purely to enable projectService. It's to switch project to projectService if project is enabled. But it doesn't apply when project: false is present.
cf71e1a to
c2c6ca1
Compare
No worries at all! At least I'm relieved that something non-trivial was going on and it wasn't just me having skill issues 😂 Oh my, that
You're awesome, thank you for all the work here! 🦸 |
I hope not... https://sourcegraph.com/search?q=context:global+TYPESCRIPT_ESLINT_PROJECT_SERVICE+-file:.*node_modules.*+-repo:%5Egithub%5C.com/typescript-eslint/typescript-eslint%24+&patternType=keyword&sm=0 shows none. I suppose we'll never know for sure though. 🤷 |
|
The ESLint lint complaint is external. |
997e0c0
into
typescript-eslint:main
|
@JoshuaKGoldberg Thank you for all the guidance and helping me get this merged! <3 |
|
It was a pleasure working with you @MariaSolOs, thanks for sticking with us on it! I hope you keep contributing 😁 |
### Developer Checklist (Definition of Done) **Issue** - [ ] All acceptance criteria from the issue are met - [ ] Tested in latest Chrome/Firefox **UI/UX/Vis** - [ ] Requires UI/UX/Vis review - [ ] Reviewer(s) are notified (_tag assignees_) - [ ] Review has occurred (_link to notes_) - [ ] Feedback is included in this PR - [ ] Reviewer(s) approve of concept and design **Code** - [ ] Branch is up-to-date with the branch to be merged with, i.e., develop - [ ] Code is cleaned up and formatted - [ ] Unit tests are written (frontend/backend if applicable) - [ ] Integration tests are written (if applicable) **PR** - [ ] Descriptive title for this pull request is provided (will be used for release notes later) - [ ] Reviewer and assignees are defined - [ ] Add type label (e.g., *bug*, *feature*) to this pull request - [ ] Add release label (e.g., `release: minor`) to this PR following [semver](https://semver.org/) - [ ] The PR is connected to the corresponding issue (via `Closes #...`) - [ ] [Summary of changes](#summary-of-changes) is written ### Summary of changes - The latest release made this change required, otherwise we would get a "Parsing error: Enabling "project" does nothing when "projectService" is enabled. You can remove the "project" setting" error - https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.46.4 (typescript-eslint/typescript-eslint#11333) ### Screenshots ### Additional notes for the reviewer(s) - Thanks for creating this pull request 🤗
* chore: prepare next dev release * fix: set projectService to false in ESLint parserOptions (#178) ### Developer Checklist (Definition of Done) **Issue** - [ ] All acceptance criteria from the issue are met - [ ] Tested in latest Chrome/Firefox **UI/UX/Vis** - [ ] Requires UI/UX/Vis review - [ ] Reviewer(s) are notified (_tag assignees_) - [ ] Review has occurred (_link to notes_) - [ ] Feedback is included in this PR - [ ] Reviewer(s) approve of concept and design **Code** - [ ] Branch is up-to-date with the branch to be merged with, i.e., develop - [ ] Code is cleaned up and formatted - [ ] Unit tests are written (frontend/backend if applicable) - [ ] Integration tests are written (if applicable) **PR** - [ ] Descriptive title for this pull request is provided (will be used for release notes later) - [ ] Reviewer and assignees are defined - [ ] Add type label (e.g., *bug*, *feature*) to this pull request - [ ] Add release label (e.g., `release: minor`) to this PR following [semver](https://semver.org/) - [ ] The PR is connected to the corresponding issue (via `Closes #...`) - [ ] [Summary of changes](#summary-of-changes) is written ### Summary of changes - The latest release made this change required, otherwise we would get a "Parsing error: Enabling "project" does nothing when "projectService" is enabled. You can remove the "project" setting" error - https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.46.4 (typescript-eslint/typescript-eslint#11333) ### Screenshots ### Additional notes for the reviewer(s) - Thanks for creating this pull request 🤗 * Prepare release version 15.1.6 --------- Co-authored-by: datavisyn-bot <> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.4 | | npm | @typescript-eslint/parser | 8.46.1 | 8.46.4 | ## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10) ##### 🩹 Fixes - **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333)) - **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730)) - **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - Kentaro Suzuki [@sushichan044](https://github.com/sushichan044) - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
|
wow, this thing causes an error - which breaks build. Please roll it back and issue a warning, instead of an error. |
We don't see this as a breaking change. We see this as a bug fix. As in, from our perspective, your config was incorrect and invalid to begin with. This change fixed the parser to correctly error when it should have before. If you see differently, please follow our contributing guide and file an issue with a reproduction. Thanks! |
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.39.1/8.47.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17) [Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0) ##### 🚀 Features - **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#​10913](typescript-eslint/typescript-eslint#10913)) ##### ❤️ Thank You - Brad Zacher [@​bradzacher](https://github.com/bradzacher) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10) [Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4) ##### 🩹 Fixes - **parser:** error when both `projectService` and `project` are set ([#​11333](typescript-eslint/typescript-eslint#11333)) - **eslint-plugin:** handle override modifier in promise-function-async fixer ([#​11730](typescript-eslint/typescript-eslint#11730)) - **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#​11006](typescript-eslint/typescript-eslint#11006), [#​10958](typescript-eslint/typescript-eslint#10958)) ##### ❤️ Thank You - Evgeny Stepanovych [@​undsoft](https://github.com/undsoft) - Kentaro Suzuki [@​sushichan044](https://github.com/sushichan044) - Maria Solano [@​MariaSolOs](https://github.com/MariaSolOs) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) [Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#​11722](typescript-eslint/typescript-eslint#11722), [#​11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#​11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@​undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) [Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#​11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13) [Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1) ##### 🩹 Fixes - **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#​11667](typescript-eslint/typescript-eslint#11667)) - **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#​11533](typescript-eslint/typescript-eslint#11533)) ##### ❤️ Thank You - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06) [Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0) ##### 🚀 Features - **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#​11659](typescript-eslint/typescript-eslint#11659)) - **rule-schema-to-typescript-types:** clean up and make public ([#​11633](typescript-eslint/typescript-eslint#11633)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#​11660](typescript-eslint/typescript-eslint#11660)) - **typescript-estree:** forbid abstract method and accessor to have implementation ([#​11657](typescript-eslint/typescript-eslint#11657)) - **eslint-plugin:** removed error type previously deprecated ([#​11674](typescript-eslint/typescript-eslint#11674)) - **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#​11603](typescript-eslint/typescript-eslint#11603)) - **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#​11634](typescript-eslint/typescript-eslint#11634)) - **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#​11628](typescript-eslint/typescript-eslint#11628)) - **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#​11487](typescript-eslint/typescript-eslint#11487)) ##### ❤️ Thank You - fisker Cheung [@​fisker](https://github.com/fisker) - Josh Goldberg ✨ - Kirk Waiblinger [@​kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@​peanutenthusiast](https://github.com/peanutenthusiast) - Richard Torres [@​richardtorres314](https://github.com/richardtorres314) - Victor Genaev [@​mainframev](https://github.com/mainframev) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29) [Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0) ##### 🚀 Features - **eslint-plugin:** expose rule name via RuleModule interface ([#​11616](typescript-eslint/typescript-eslint#11616)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#​11614](typescript-eslint/typescript-eslint#11614)) - **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#​11617](typescript-eslint/typescript-eslint#11617)) ##### ❤️ Thank You - mdm317 - Moses Odutusin [@​thebolarin](https://github.com/thebolarin) - Yukihiro Hasegawa [@​y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) [Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#​11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#​11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#​11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@​kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15) [Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0) ##### 🚀 Features - **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#​11267](typescript-eslint/typescript-eslint#11267)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#​11490](typescript-eslint/typescript-eslint#11490)) ##### ❤️ Thank You - Moses Odutusin [@​thebolarin](https://github.com/thebolarin) - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08) [Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0) ##### 🚀 Features - **typescript-estree:** disallow empty type parameter/argument lists ([#​11563](typescript-eslint/typescript-eslint#11563)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#​11432](typescript-eslint/typescript-eslint#11432)) - **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#​11359](typescript-eslint/typescript-eslint#11359)) - **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#​11423](typescript-eslint/typescript-eslint#11423), [#​11430](typescript-eslint/typescript-eslint#11430)) - **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#​11457](typescript-eslint/typescript-eslint#11457)) - **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#​11517](typescript-eslint/typescript-eslint#11517)) - **scope-manager:** exclude Program from DefinitionBase node types ([#​11469](typescript-eslint/typescript-eslint#11469)) - **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#​11489](typescript-eslint/typescript-eslint#11489)) - **type-utils:** add union type support to TypeOrValueSpecifier ([#​11526](typescript-eslint/typescript-eslint#11526)) ##### ❤️ Thank You - Dima [@​dbarabashh](https://github.com/dbarabashh) - Kirk Waiblinger [@​kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - tao - Victor Genaev [@​mainframev](https://github.com/mainframev) - Yukihiro Hasegawa [@​y-hsgw](https://github.com/y-hsgw) - 민감자(Minji Kim) [@​mouse0429](https://github.com/mouse0429) - 송재욱 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8420-2025-09-02) [Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0) ##### 🩹 Fixes - **deps:** update eslint monorepo to v9.33.0 ([#​11482](typescript-eslint/typescript-eslint#11482)) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8410-2025-08-25) [Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0) ##### 🩹 Fixes - **deps:** update dependency prettier to v3.6.2 ([#​11496](typescript-eslint/typescript-eslint#11496)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8400-2025-08-18) [Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0) ##### 🚀 Features - **typescript-estree:** forbid invalid keys in `EnumMember` ([#​11232](typescript-eslint/typescript-eslint#11232)) ##### ❤️ Thank You - fisker Cheung [@​fisker](https://github.com/fisker) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8470-2025-11-17) [Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8464-2025-11-10) [Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8463-2025-11-03) [Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8462-2025-10-20) [Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8461-2025-10-13) [Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8460-2025-10-06) [Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8450-2025-09-29) [Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8441-2025-09-22) [Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8440-2025-09-15) [Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8430-2025-09-08) [Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8420-2025-09-02) [Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8410-2025-08-25) [Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8400-2025-08-18) [Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/20 Co-authored-by: Renovate Bot <renovate@csmpro.ru> Co-committed-by: Renovate Bot <renovate@csmpro.ru>
|
I understand the fix is not seen as a breaking change, but actually it is breaking my build currently when updating my packages. Using Wanted to leave this comment here for anyone running into the same issue. If possible, would be great if the error message can be improved to better indicate what config is causing the error. |
|
Uh oh! @GKersten, at least one image you shared is missing helpful alt text. Check #11333 (comment) to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 | | npm | @typescript-eslint/parser | 8.46.1 | 8.47.0 | ## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17) ##### 🚀 Features - **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10) ##### 🩹 Fixes - **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333)) - **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730)) - **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - Kentaro Suzuki [@sushichan044](https://github.com/sushichan044) - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 | | npm | @typescript-eslint/parser | 8.46.1 | 8.47.0 | ## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17) ##### 🚀 Features - **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10) ##### 🩹 Fixes - **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333)) - **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730)) - **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - Kentaro Suzuki [@sushichan044](https://github.com/sushichan044) - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 | | npm | @typescript-eslint/parser | 8.46.1 | 8.47.0 | ## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17) ##### 🚀 Features - **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10) ##### 🩹 Fixes - **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333)) - **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730)) - **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - Kentaro Suzuki [@sushichan044](https://github.com/sushichan044) - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
…ectories with 4 updates (#91) * Bump the minor-updates group across 2 directories with 4 updates Bumps the minor-updates group with 4 updates in the / directory: [hmrc-frontend](https://github.com/hmrc/hmrc-frontend), [openai](https://github.com/openai/openai-node), [prettier](https://github.com/prettier/prettier) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint). Bumps the minor-updates group with 1 update in the /data/zip-download directory: [hmrc-frontend](https://github.com/hmrc/hmrc-frontend). Updates `hmrc-frontend` from 6.100.0 to 6.103.0 - [Release notes](https://github.com/hmrc/hmrc-frontend/releases) - [Changelog](https://github.com/hmrc/hmrc-frontend/blob/main/CHANGELOG.md) - [Commits](hmrc/hmrc-frontend@v6.100.0...v6.103.0) Updates `openai` from 6.8.1 to 6.9.1 - [Release notes](https://github.com/openai/openai-node/releases) - [Changelog](https://github.com/openai/openai-node/blob/master/CHANGELOG.md) - [Commits](openai/openai-node@v6.8.1...v6.9.1) Updates `prettier` from 3.6.2 to 3.7.0 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.6.2...3.7.0) Updates `typescript-eslint` from 8.46.0 to 8.48.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.48.0/packages/typescript-eslint) Updates `hmrc-frontend` from 6.100.0 to 6.103.0 - [Release notes](https://github.com/hmrc/hmrc-frontend/releases) - [Changelog](https://github.com/hmrc/hmrc-frontend/blob/main/CHANGELOG.md) - [Commits](hmrc/hmrc-frontend@v6.100.0...v6.103.0) Updates `hmrc-frontend` from 6.100.0 to 6.103.0 - [Release notes](https://github.com/hmrc/hmrc-frontend/releases) - [Changelog](https://github.com/hmrc/hmrc-frontend/blob/main/CHANGELOG.md) - [Commits](hmrc/hmrc-frontend@v6.100.0...v6.103.0) Updates `hmrc-frontend` from 6.100.0 to 6.103.0 - [Release notes](https://github.com/hmrc/hmrc-frontend/releases) - [Changelog](https://github.com/hmrc/hmrc-frontend/blob/main/CHANGELOG.md) - [Commits](hmrc/hmrc-frontend@v6.100.0...v6.103.0) --- updated-dependencies: - dependency-name: hmrc-frontend dependency-version: 6.103.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-updates - dependency-name: openai dependency-version: 6.9.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-updates - dependency-name: prettier dependency-version: 3.7.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-updates - dependency-name: typescript-eslint dependency-version: 8.48.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-updates - dependency-name: hmrc-frontend dependency-version: 6.103.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-updates - dependency-name: hmrc-frontend dependency-version: 6.103.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-updates - dependency-name: hmrc-frontend dependency-version: 6.103.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-updates ... Signed-off-by: dependabot[bot] <support@github.com> * Update ESLint config See https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.46.4 and typescript-eslint/typescript-eslint#11333 * Set npm version to v11.6.1 This release corrects the peer dependency flag propagation. See https://docs.npmjs.com/cli/v11/using-npm/changelog#1161-2025-09-23 and npm/cli#8579 * Upgrade npm to v11.6.1 in code-quality.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christopher Menon <16004217+cmenon12@users.noreply.github.com>

PR Checklist
projectServiceandprojectare set #11319Overview
As mentioned in the issue, the docs aren't clear of what the parser will use when both
projectServiceandprojectare set. When such case is detected, I think it's better to be explicit about the misconfiguration and error as early as possible.