fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment #11489

y-hsgw · 2025-08-16T14:30:39Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-non-null-assertion] wrong suggestion on left-hand side of an assignment #11473
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Avoid suggestions for non-null assertions in assignee positions to prevent invalid auto-fixes.

🐛

typescript-eslint · 2025-08-16T14:30:43Z

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-08-16T14:30:44Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`0b0b179`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68b1620b269f490008a89da3
😎 Deploy Preview	https://deploy-preview-11489--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (no change from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-08-16T14:32:04Z

View your CI Pipeline Execution ↗ for commit 0b0b179

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 12s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 16s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 10s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	7s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-29 08:27:53 UTC

…to fix/no-non-null-assertion

kirkwaiblinger

The logic change looks correct but requesting a couple finishing touches. Thanks!

kirkwaiblinger · 2025-08-27T18:46:53Z

packages/eslint-plugin/tests/rules/no-non-null-assertion.test.ts

      ],
    },
+    {
+      code: noFormat`


These tests don't appear to test anything related to formatting. Could you remove the noFormat please unless there is a specific reason for them?

Suggested change

code: noFormat`

code: `

Sorry about that.. I fixed it in 3248823!

packages/eslint-plugin/tests/rules/no-non-null-assertion.test.ts

codecov · 2025-08-28T07:37:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (264ca2f) to head (0b0b179).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11489   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files         505      505           
  Lines       51146    51147    +1     
  Branches     8424     8425    +1     
=======================================
+ Hits        46480    46481    +1     
  Misses       4652     4652           
  Partials       14       14

Flag	Coverage Δ
unittest	`90.87% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/eslint-plugin/src/rules/no-non-null-assertion.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kirkwaiblinger

🥳

JoshuaKGoldberg

Lovely!

@dbarabashh

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 | | npm | @typescript-eslint/parser | 8.42.0 | 8.43.0 | ## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08) ##### 🚀 Features - **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432)) - **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359)) - **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430)) - **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457)) - **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517)) - **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469)) - **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489)) - **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526)) ##### ❤️ Thank You - Dima [@dbarabashh](https://github.com/dbarabashh) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - tao - Victor Genaev [@mainframev](https://github.com/mainframev) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) - 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429) - 송재욱 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17) [Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0) ##### 🚀 Features - **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10) [Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4) ##### 🩹 Fixes - **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333)) - **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730)) - **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - Kentaro Suzuki [@sushichan044](https://github.com/sushichan044) - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) [Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) [Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13) [Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1) ##### 🩹 Fixes - **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#11667](typescript-eslint/typescript-eslint#11667)) - **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#11533](typescript-eslint/typescript-eslint#11533)) ##### ❤️ Thank You - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06) [Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0) ##### 🚀 Features - **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659)) - **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660)) - **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657)) - **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674)) - **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603)) - **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634)) - **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628)) - **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487)) ##### ❤️ Thank You - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg ✨ - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Richard Torres [@richardtorres314](https://github.com/richardtorres314) - Victor Genaev [@mainframev](https://github.com/mainframev) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29) [Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0) ##### 🚀 Features - **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614)) - **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617)) ##### ❤️ Thank You - mdm317 - Moses Odutusin [@thebolarin](https://github.com/thebolarin) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) [Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15) [Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0) ##### 🚀 Features - **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#11267](typescript-eslint/typescript-eslint#11267)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#11490](typescript-eslint/typescript-eslint#11490)) ##### ❤️ Thank You - Moses Odutusin [@thebolarin](https://github.com/thebolarin) - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08) [Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0) ##### 🚀 Features - **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432)) - **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359)) - **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430)) - **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457)) - **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517)) - **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469)) - **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489)) - **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526)) ##### ❤️ Thank You - Dima [@dbarabashh](https://github.com/dbarabashh) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - tao - Victor Genaev [@mainframev](https://github.com/mainframev) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) - 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429) - 송재욱 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8420-2025-09-02) [Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0) ##### 🩹 Fixes - **deps:** update eslint monorepo to v9.33.0 ([#11482](typescript-eslint/typescript-eslint#11482)) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8410-2025-08-25) [Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0) ##### 🩹 Fixes - **deps:** update dependency prettier to v3.6.2 ([#11496](typescript-eslint/typescript-eslint#11496)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8400-2025-08-18) [Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0) ##### 🚀 Features - **typescript-estree:** forbid invalid keys in `EnumMember` ([#11232](typescript-eslint/typescript-eslint#11232)) ##### ❤️ Thank You - fisker Cheung [@fisker](https://github.com/fisker) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8470-2025-11-17) [Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8464-2025-11-10) [Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8463-2025-11-03) [Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8462-2025-10-20) [Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8461-2025-10-13) [Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8460-2025-10-06) [Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8450-2025-09-29) [Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8441-2025-09-22) [Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8440-2025-09-15) [Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8430-2025-09-08) [Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8420-2025-09-02) [Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8410-2025-08-25) [Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8400-2025-08-18) [Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/20 Co-authored-by: Renovate Bot <renovate@csmpro.ru> Co-committed-by: Renovate Bot <renovate@csmpro.ru>

y-hsgw added 2 commits August 16, 2025 23:26

fix: disable suggestion when non-null assertion is used as an assignee

a0da01b

test: add tests

f0feb9e

y-hsgw and others added 4 commits August 16, 2025 23:45

chore: fix lint errors

9aaa525

Merge branch 'main' of https://github.com/y-hsgw/typescript-eslint in…

a37427a

…to fix/no-non-null-assertion

Merge branch 'main' into fix/no-non-null-assertion

ebc94de

Merge branch 'main' into fix/no-non-null-assertion

d2e2ef6

kirkwaiblinger changed the title ~~fix(eslint-plugin): [no-non-null-assertion] wrong suggestion on left-hand side of an assignment~~ fix(eslint-plugin): [no-non-null-assertion] do not suggestion optional chain on LHS of assignment Aug 27, 2025

kirkwaiblinger changed the title ~~fix(eslint-plugin): [no-non-null-assertion] do not suggestion optional chain on LHS of assignment~~ fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment Aug 27, 2025

kirkwaiblinger requested changes Aug 27, 2025

View reviewed changes

kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Aug 27, 2025

y-hsgw added 2 commits August 28, 2025 11:18

test: remove noFormat

3248823

test: fix test output

dd0bcd1

y-hsgw and others added 4 commits August 28, 2025 17:06

chore: fix lint

2ae4c82

Merge branch 'main' into fix/no-non-null-assertion

f04d699

test: fix test output

0ad658a

test: fix test output

cf7965b

y-hsgw requested a review from kirkwaiblinger August 28, 2025 09:08

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 28, 2025

kirkwaiblinger approved these changes Aug 29, 2025

View reviewed changes

Merge branch 'main' into fix/no-non-null-assertion

0b0b179

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 29, 2025

JoshuaKGoldberg approved these changes Sep 3, 2025

View reviewed changes

JoshuaKGoldberg merged commit 08e242c into typescript-eslint:main Sep 3, 2025
64 checks passed

y-hsgw deleted the fix/no-non-null-assertion branch September 3, 2025 11:28

chrisbbreuer mentioned this pull request Sep 8, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#54

Closed

chrisbbreuer mentioned this pull request Sep 18, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#64

Closed

fossabot bot mentioned this pull request Sep 29, 2025

Bump @typescript-eslint/eslint-plugin from 8.42.0 to 8.44.1 fossas/fossa-action#210

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment #11489

fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment #11489

Uh oh!

y-hsgw commented Aug 16, 2025 •

edited

Loading

Uh oh!

typescript-eslint bot commented Aug 16, 2025

Uh oh!

netlify bot commented Aug 16, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Aug 16, 2025 •

edited

Loading

Uh oh!

kirkwaiblinger left a comment

Uh oh!

kirkwaiblinger Aug 27, 2025

Uh oh!

y-hsgw Aug 28, 2025

Uh oh!

Uh oh!

codecov bot commented Aug 28, 2025 •

edited

Loading

Uh oh!

kirkwaiblinger left a comment

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment #11489

fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment #11489

Uh oh!

Conversation

y-hsgw commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Aug 16, 2025

Uh oh!

netlify bot commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

y-hsgw Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

y-hsgw commented Aug 16, 2025 •

edited

Loading

netlify bot commented Aug 16, 2025 •

edited

Loading

nx-cloud bot commented Aug 16, 2025 •

edited

Loading

codecov bot commented Aug 28, 2025 •

edited

Loading