🌐 AI搜索 & 代理 主页
Skip to content

chore: use new ESLint rules internally #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kirkwaiblinger merged 3 commits into from
Sep 1, 2025
Merged

chore: use new ESLint rules internally #11558

kirkwaiblinger merged 3 commits into from
Sep 1, 2025

Conversation

@kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Sep 1, 2025

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 1, 2025

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fc33374
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68b5a09c1de10a00081b64d3
😎 Deploy Preview https://deploy-preview-11558--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fc33374

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 10s View ↗
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 16s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 12s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-01 13:45:33 UTC

kirkwaiblinger
kirkwaiblinger commented Sep 1, 2025
View reviewed changes
packages/scope-manager/src/referencer/ClassVisitor.ts
Copy link
Member Author

@kirkwaiblinger kirkwaiblinger Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was dead code left from the cleanup in #8335

@kirkwaiblinger kirkwaiblinger changed the title chore: Use new ESLint rules internally chore: use new ESLint rules internally Sep 1, 2025
@codecov
Copy link

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (fa15645) to head (fc33374).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11558      +/-   ##
==========================================
+ Coverage   90.84%   90.90%   +0.05%     
==========================================
  Files         505      505              
  Lines       51170    51121      -49     
  Branches     8423     8417       -6     
==========================================
- Hits        46485    46469      -16     
+ Misses       4671     4639      -32     
+ Partials       14       13       -1
Flag Coverage Δ
unittest 90.90% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/eslint-plugin/src/util/getFunctionHeadLoc.ts 97.46% <100.00%> (ø)
packages/rule-tester/src/RuleTester.ts 73.78% <100.00%> (ø)
...kages/scope-manager/src/referencer/ClassVisitor.ts 92.89% <100.00%> (+12.72%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 1, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) September 1, 2025 13:33
@kirkwaiblinger kirkwaiblinger merged commit 0daf303 into typescript-eslint:main Sep 1, 2025
59 of 61 checks passed
@kirkwaiblinger kirkwaiblinger deleted the use-new-lint-rules branch September 1, 2025 15:21
@abrahamguo abrahamguo mentioned this pull request Sep 26, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Use new ESLint rules no-useless-assignment and no-unassigned-var

3 participants

@kirkwaiblinger @JoshuaKGoldberg @bradzacher