chore(website): lint for missing g flag
#11645
Conversation
|
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit f1c142e
☁️ Nx Cloud last updated this comment at |
g flagg flag
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Nice, thanks as always! ✨
g flagg flag
PR Checklist
Overview
While looking into other website issues, I noticed that @kirkwaiblinger's work in #11558 introduced a runtime error, because it removed a
gflag from a regular expression that is passed toString#matchAll, which does require agflag.This PR fixes this issue, as well as enabling
regexp/no-missing-g-flag(which did successfully identify this issue) to prevent this from occurring again.