chore: check VariableDeclaration syntax error against tsNode
#11777
Conversation
|
Thanks for the PR, @fisker! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 0603fcb
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11777 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 522 522
Lines 53079 53076 -3
Branches 8842 8842
=======================================
Hits 48074 48074
+ Misses 4989 4987 -2
+ Partials 16 15 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
f8b2bb4
into
typescript-eslint:main
PR Checklist
Overview
The syntax check should always check against TS node instead of ESTree node before convert, prepare for #11695
VariableStatementcheck also checking against ESTree node, but it's quite complex, will give another try in seperate PR.