chore: check variable declaration syntax error against tsNode #11778
Conversation
|
Thanks for the PR, @fisker! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit a7fdcfc
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (40.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11778 +/- ##
==========================================
+ Coverage 90.53% 90.55% +0.01%
==========================================
Files 523 523
Lines 53097 53105 +8
Branches 8838 8839 +1
==========================================
+ Hits 48074 48088 +14
+ Misses 5010 5004 -6
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
This seems reasonable to me, thanks!
+1 to merging in #11777 first.
# Conflicts: # packages/typescript-estree/src/convert.ts
PR Checklist
Overview
Same as #11777
No logic changes, just refactor.
Note: this contains changes from #11777, but fixed both
VariableDeclaration,VariableDeclarationList, andVariableStatement.If smaller changes are preferred, I'll rebase after #11777 gets merged.