🌐 AI搜索 & 代理 主页
Skip to content

fix(eslint-plugin): [method-signature-style] ignore methods that return this #11813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JoshuaKGoldberg wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(eslint-plugin): [method-signature-style] ignore methods that return this #11813

JoshuaKGoldberg wants to merge 4 commits into from
+168 −42

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 1, 2025

PR Checklist

Overview

Adds a utility method to recurse through the AST similar to ts.forEachChild.

💖

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Dec 1, 2025

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2d80906
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/692dce3ee80ead000858b09e
😎 Deploy Preview https://deploy-preview-11813--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2d80906

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 13s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 56s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-01 17:32:15 UTC

@codecov
Copy link

codecov bot commented Dec 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.54%. Comparing base (5ac66a6) to head (2d80906).

Files with missing lines Patch % Lines
.../eslint-plugin/src/rules/method-signature-style.ts 96.49% 2 Missing ⚠️
packages/eslint-plugin/src/util/astUtils.ts 95.34% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11813   +/-   ##
=======================================
  Coverage   90.53%   90.54%           
=======================================
  Files         523      523           
  Lines       53097    53155   +58     
  Branches     8838     8856   +18     
=======================================
+ Hits        48074    48128   +54     
- Misses       5010     5014    +4     
  Partials       13       13
Flag Coverage Δ
unittest 90.54% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts 93.01% <96.49%> (-0.45%) ⬇️
packages/eslint-plugin/src/util/astUtils.ts 95.78% <95.34%> (-0.37%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg requested review from a team and removed request for a team December 1, 2025 16:12
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft December 1, 2025 16:15
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 1, 2025 18:48
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team December 1, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[method-signature-style] Shouldn't affect methods that use this

1 participant

@JoshuaKGoldberg